Skip to content

Doc global require authenticated users #18825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 24, 2020
Merged

Doc global require authenticated users #18825

merged 9 commits into from
Jul 24, 2020

Conversation

@Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Jun 17, 2020 •
edited
Loading

@Rick-Anderson Rick-Anderson marked this pull request as draft June 17, 2020 03:04
@Rick-Anderson Rick-Anderson marked this pull request as ready for review June 18, 2020 01:42
@Rick-Anderson Rick-Anderson requested a review from HaoK June 18, 2020 01:42
@Rick-Anderson Rick-Anderson requested review from HaoK and removed request for HaoK June 18, 2020 02:45
@Rick-Anderson Rick-Anderson changed the title Doc global require authenticated usesrs Doc global require authenticated users Jun 18, 2020
@guardrex guardrex mentioned this pull request Jun 19, 2020
Closed
@Rick-Anderson
Copy link
Contributor Author

Rick-Anderson commented Jun 24, 2020

@HaoK Short review when you have time

@Rick-Anderson Rick-Anderson requested review from blowdart and removed request for HaoK June 26, 2020 22:32
@Rick-Anderson
Copy link
Contributor Author

Rick-Anderson commented Jul 15, 2020

@blowdart Short review when you have time.

@Rick-Anderson
Copy link
Contributor Author

Rick-Anderson commented Jul 21, 2020

@blowdart can you do a quick review or @HaoK since he's familiar with the issue that started this.

HaoK
HaoK approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@HaoK HaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @blowdart @Tratcher and @pranavkm should take a quick look too

Tratcher
Tratcher reviewed Jul 21, 2020
View reviewed changes
@Rick-Anderson Rick-Anderson requested a review from Tratcher July 21, 2020 23:06
@Rick-Anderson Rick-Anderson mentioned this pull request Jul 21, 2020
Closed
@Rick-Anderson
Copy link
Contributor Author

Rick-Anderson commented Jul 24, 2020

@serpent5 please review and make sure my changes addressed @Tratcher feedback.

Tratcher
Tratcher approved these changes Jul 24, 2020
View reviewed changes
@Rick-Anderson Rick-Anderson merged commit fb30189 into master Jul 24, 2020
@Rick-Anderson Rick-Anderson deleted the require/authentication/ra branch July 24, 2020 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

@HaoK HaoK HaoK approved these changes

@blowdart blowdart Awaiting requested review from blowdart

+1 more reviewer

@pranavkm pranavkm pranavkm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update to endpoint routing fallback authentication policy

5 participants

@Rick-Anderson @pranavkm @Tratcher @HaoK