-
Notifications
You must be signed in to change notification settings - Fork 161
Problem detail service middleware sample code #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Rick-Anderson
merged 20 commits into
dotnet:main
from
sammychinedu2ky:problem-detail-service-middleware
Sep 2, 2022
Merged
Problem detail service middleware sample code #25
Rick-Anderson
merged 20 commits into
dotnet:main
from
sammychinedu2ky:problem-detail-service-middleware
Sep 2, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunolins16
suggested changes
Aug 31, 2022
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
…m/sammychinedu2ky/AspNetCore.Docs.Samples into problem-detail-service-middleware
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
brunolins16
reviewed
Sep 1, 2022
brunolins16
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just some nits. Thanks for the contribution.
fundamentals/middleware/problem-details-service/problem-details-service.csproj
Show resolved
Hide resolved
fundamentals/middleware/problem-details-service/problem-details-service.csproj
Outdated
Show resolved
Hide resolved
fundamentals/middleware/problem-details-service/problem-details-service.csproj
Show resolved
Hide resolved
Co-authored-by: Bruno Oliveira <[email protected]>
@Rick-Anderson I don't have permissions to merge this PR, but this looks good to me. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Rick-Anderson I added sample code for this issue dotnet/AspNetCore.Docs#26685