Skip to content

fix: exports for react native #7201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2021
Merged

fix: exports for react native #7201

merged 2 commits into from
Dec 14, 2021

Conversation

stelmakhivan
Copy link
Contributor

#6599
Examples from other open-source libraries
graphql-eslint
react-hook-form
zora
effector
react-final-table

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 7f62a9b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 13, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/graphql-code-generator/AeZLN3BDbKym5tpuNJGkEudE1hmT
✅ Preview: https://graphql-code-generator-git-fork-stelmakhivan-bu-c83f28-theguild.vercel.app

n1ru4l
n1ru4l requested changes Dec 13, 2021
View reviewed changes
Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stelmakhivan could you please add a changeset for all those packages?

@stelmakhivan stelmakhivan force-pushed the bugfix/exports_for_react_native branch from 49f45ac to 96862d8 Compare December 14, 2021 08:06
@n1ru4l
Copy link
Collaborator

n1ru4l commented Dec 14, 2021

@stelmakhivan Could you please change the change type from minor to patch?

@stelmakhivan stelmakhivan requested a review from n1ru4l December 14, 2021 08:45
@stelmakhivan stelmakhivan force-pushed the bugfix/exports_for_react_native branch from fb48d66 to 7f62a9b Compare December 14, 2021 09:43
@stelmakhivan
Copy link
Contributor Author

sure. the same here
graphql-hive/graphql-eslint#841

@n1ru4l n1ru4l merged commit 6002feb into dotansimha:master Dec 14, 2021
@stelmakhivan stelmakhivan deleted the bugfix/exports_for_react_native branch December 21, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@n1ru4l n1ru4l Awaiting requested review from n1ru4l

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stelmakhivan @n1ru4l