Skip to content

staticcheck: recognize more options in JSON tags #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

staticcheck: recognize more options in JSON tags #1266

wants to merge 1 commit into from

Conversation

dsnet
Copy link
Contributor

@dsnet dsnet commented May 7, 2022

These are supported by a prototype implementation of json.

dominikh
dominikh requested changes May 7, 2022
View reviewed changes
@dsnet
staticcheck: recognize more options in JSON tags
e1aec56 
These are supported by a prototype implementation of json.
@dsnet
Copy link
Contributor Author

dsnet commented May 7, 2022

I made a change to the format: flag to simply ignore everything afterwards. This might have some false negatives, but that's okay for now.

dsnet
dsnet commented May 7, 2022
View reviewed changes
@dominikh dominikh closed this in 003d277 May 7, 2022
@dominikh
Copy link
Owner

dominikh commented May 7, 2022

Thanks!

dominikh pushed a commit that referenced this pull request May 16, 2022
@dsnet @dominikh
staticcheck: recognize more options in JSON tags
e8f2251 
These are supported by a prototype implementation of json.

Closes: gh-1266 [via git-merge-pr]
(cherry picked from commit 003d277)
dominikh pushed a commit that referenced this pull request May 16, 2022
@dsnet @dominikh
staticcheck: recognize more options in JSON tags
7ef9e7d 
These are supported by a prototype implementation of json.

Closes: gh-1266 [via git-merge-pr]
(cherry picked from commit 003d277)
@CarlJi CarlJi mentioned this pull request Apr 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikh dominikh dominikh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsnet @dominikh