-
-
Notifications
You must be signed in to change notification settings - Fork 21
enable usage of pyproject.toml
#37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sneaky change: enable settings for this library to be collected under the libraries name
for more information, see https://pre-commit.ci
|
Please let me know, what your opinion is and what you think might be necessary to get this merged and released. I like the library and would like to keep using it, even thought the usual setup.py is depricated now. Using a |
|
Seeing multiple failures for old python versions due to the used library "tomli". I could brew my own toml reader if necessary. How important is the compatibility with those old python versions? |
pyprojec.tomlpyproject.toml
|
Hello, thank you for the PR! |
It looks like |
Indeed. I changed the PR to use |
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 88.66% 83.53% -5.14%
==========================================
Files 1 1
Lines 150 164 +14
Branches 32 35 +3
==========================================
+ Hits 133 137 +4
- Misses 15 24 +9
- Partials 2 3 +1
Continue to review full report at Codecov.
|
|
I've dropped support of 3.3 and 3.4 in the master branch. CI/CD pipeline is very unstable because of them, and also there is no actual need to spend so much time to support these versions. So you can return I'm also thinking about dropping support of 2.7-3.6 in some future release, but let's merge this PR first |
|
Thank you very much. If you have some holiday days currently: enjoy. And in any case: Take care. |
|
Oh! You updated my branch. I misunderstood the merge. I'm reopening the Pullrequest and hope for the change/update merge into your repository. |
Enable a
pyproject.tomlto prepare a library to use setuptools-got-versioning.In addition I added some code to enable settings for this library to be collected under the libraries name. Therefore one can now write the following in the known
setup.py:Documentation was adjusted accordingly.
fixes the spirit of #35