Skip to content

Conversation

@Bloodmallet
Copy link

Enable a pyproject.toml to prepare a library to use setuptools-got-versioning.
In addition I added some code to enable settings for this library to be collected under the libraries name. Therefore one can now write the following in the known setup.py:

setuptools.setup(setuptools_git_versioning=True, setup_requires=["setuptools-git-versioning"], ...)

Documentation was adjusted accordingly.

fixes the spirit of #35

@Bloodmallet
Copy link
Author

Please let me know, what your opinion is and what you think might be necessary to get this merged and released. I like the library and would like to keep using it, even thought the usual setup.py is depricated now. Using a pyproject.toml file is the way to go.

@Bloodmallet
Copy link
Author

Seeing multiple failures for old python versions due to the used library "tomli". I could brew my own toml reader if necessary. How important is the compatibility with those old python versions?

@Bloodmallet Bloodmallet changed the title enable usage of pyprojec.toml enable usage of pyproject.toml Dec 18, 2021
@dolfinus
Copy link
Owner

Hello, thank you for the PR!

@dolfinus
Copy link
Owner

Seeing multiple failures for old python versions due to the used library "tomli". I could brew my own toml reader if necessary. How important is the compatibility with those old python versions?

It looks like toml package does support 3.3 and 3.4

@Bloodmallet
Copy link
Author

It looks like toml package does support 3.3 and 3.4

Indeed. I changed the PR to use toml instead. I forgot to remove my comment.

@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #37 (de3d03f) into master (848fa5b) will decrease coverage by 5.13%.
The diff coverage is 58.33%.

❗ Current head de3d03f differs from pull request most recent head e2a8585. Consider uploading reports for the commit e2a8585 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   88.66%   83.53%   -5.14%     
==========================================
  Files           1        1              
  Lines         150      164      +14     
  Branches       32       35       +3     
==========================================
+ Hits          133      137       +4     
- Misses         15       24       +9     
- Partials        2        3       +1     
Impacted Files Coverage Δ
setuptools_git_versioning.py 83.53% <58.33%> (-5.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcec019...e2a8585. Read the comment docs.

@dolfinus
Copy link
Owner

dolfinus commented Dec 27, 2021

I've dropped support of 3.3 and 3.4 in the master branch. CI/CD pipeline is very unstable because of them, and also there is no actual need to spend so much time to support these versions. So you can return tomli back.

I'm also thinking about dropping support of 2.7-3.6 in some future release, but let's merge this PR first

@Bloodmallet
Copy link
Author

Thank you very much. If you have some holiday days currently: enjoy. And in any case: Take care.

@Bloodmallet
Copy link
Author

Oh! You updated my branch. I misunderstood the merge. I'm reopening the Pullrequest and hope for the change/update merge into your repository.

@Bloodmallet Bloodmallet reopened this Dec 27, 2021
@dolfinus dolfinus enabled auto-merge (rebase) December 28, 2021 10:03
auto-merge was automatically disabled December 28, 2021 10:06

Rebase failed

@dolfinus dolfinus merged commit 62c14a0 into dolfinus:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants