Skip to content

Conversation

NoCLin
Copy link

@NoCLin NoCLin commented Jul 31, 2018

Fixed #590, but some links should be updated.

For example, in /docs/_sidebar.md line 3: * [Quick start](quickstart.md)

old:

  • quickstart.md refers to /quickstart

new:

  • /quickstart.md refers to /quickstart
  • quickstart.md refers to ./quickstart
  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

@jingsam
Copy link
Contributor

jingsam commented Jul 31, 2018

This PR is a non compatible change, as it behaves different with the original URL parsing. Some docsify docs sites maybe down because of this PR. However, this PR sounds logic and reasonable. So, maybe we needs a major update in docsify version.

@QingWei-Li QingWei-Li mentioned this pull request Oct 28, 2018
5 tasks
@timaschew
Copy link
Member

@NoCLin thank you. I'm closing this in favor of #714 which fixing same bug but without breaking change behaviour.

@timaschew timaschew closed this Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants