Skip to content

Conversation

@fanktom
Copy link

@fanktom fanktom commented Aug 15, 2017

An idiomatic go function returns value, nil or nil, error on error.

The current implementation requires that on error the implementer of a driver returns an empty response struct and an error. This PR allows to return an nil, error as one would expect, does not break tests or the API.

Currently:

return &GetResponse{}, errors.New("some error")

After PR:

return nil, errors.New("some error")

Further, the current API still works the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant