Windows: Support named pipe hardening #148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Dumb question:
What happens if the plugin crashes? |
In production plugins only NT AUTHORITY\SYSTEM which run Docker engine should have access plugin named pipes. Signed-off-by: Olli Janatuinen <[email protected]>
olljanat
force-pushed
the
namedpipe-hardening
branch
from
baf0e4e to
e1209e5
Compare
Author
This seems to be invalid comments which I had forgot to there. On some earlier draft I had added Removed it now also from commit message.
It closes normally. User mode services cannot leave named pipes behind when they close/crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production plugins only NT AUTHORITY\SYSTEM which run Docker engine should have access plugin named pipes.