engine: safer creation of rootlesskit apparmor profile #23642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Karlsson <[email protected]>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
area/engine
vvoland
reviewed
Nov 4, 2025
|
|
||
| ```console | ||
| $ filename=$(echo $HOME/bin/rootlesskit | sed -e s@^/@@ -e s@/@.@g) | ||
| $ export filename=$(echo $HOME/bin/rootlesskit | sed -e s@^/@@ -e s@/@.@g) |
Contributor
There was a problem hiding this comment.
export is probably not needed here.
We should probably quote the sed commands just to be sure:
Suggested change
| $ export filename=$(echo $HOME/bin/rootlesskit | sed -e s@^/@@ -e s@/@.@g) | |
| $ filename=$(echo $HOME/bin/rootlesskit | sed -e 's@^/@@' -e 's@/@.@g') |
Comment on lines
29
to
39
| $ cat <<EOF > ~/${filename} | ||
| abi <abi/4.0>, | ||
| include <tunables/global> | ||
|
|
||
| "$HOME/bin/rootlesskit" flags=(unconfined) { | ||
| userns, | ||
|
|
||
| include if exists <local/${filename}> | ||
| } | ||
| EOF | ||
| $ sudo mv ~/${filename} /etc/apparmor.d/${filename} | ||
| $ [ -f ~/"${filename}" ] && sudo mv ~/${filename} /etc/apparmor.d/${filename} |
Contributor
There was a problem hiding this comment.
We could probably write directly to the target file:
Suggested change
| $ [ -f ~/"${filename}" ] && sudo cat <<EOF > /etc/apparmor.d/${filename} | |
| abi <abi/4.0>, | |
| include <tunables/global> | |
| @@ -36,7 +36,7 @@ | |
| include if exists <local/${filename}> | |
| } | |
| EOF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Karlsson [email protected]
Description
The current instruction is technically incorrect since we are not exporting the
filenamevariable and the instruction suggests that users should run thisdiscretely. This PR adds an
exportstatement as well as a quick check to makesure the file exists before attempting to move it into the apparmor directory
(to prevent users from accidentally
sudo mving their home directory there incase
$filenameis unset)Related issues or tickets