-
Notifications
You must be signed in to change notification settings - Fork 425
Address build warnings #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address build warnings #779
Conversation
The following warnings are emitted by `docker build`: ``` 19 warnings found (use docker --debug to expand): - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 204) - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "RABBITMQ_PGP_KEY_ID") (line 235) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 239) - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 9) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 32) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 199) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 206) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 235) - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "OPENSSL_PGP_KEY_IDS") (line 35) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 37) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 43) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 44) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 233) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 236) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 305) - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 22) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 192) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 200) - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 115) ``` This PR addresses them.
|
I don't put much stock in any of these (and have consistently and actively opposed the implementation of one in particular: moby/buildkit#5130), but I won't block this if you feel strongly about them. Some further added context:
|
|
Thanks for the context links. I don't feel strongly about them but I also don't like seeing warnings when I build containers to test PRs here 😸 |
Changes: - docker-library/rabbitmq@1519c4c: Merge pull request docker-library/rabbitmq#779 from lukebakken/lukebakken/fix-warnings
Changes: - docker-library/rabbitmq@85ee627: Update 4.0 to 4.0.8 - docker-library/rabbitmq@1519c4c: Merge pull request docker-library/rabbitmq#779 from lukebakken/lukebakken/fix-warnings
Changes: - docker-library/rabbitmq@c879782: Update 4.0 to 4.0.9 - docker-library/rabbitmq@85ee627: Update 4.0 to 4.0.8 - docker-library/rabbitmq@1519c4c: Merge pull request docker-library/rabbitmq#779 from lukebakken/lukebakken/fix-warnings
Changes: - docker-library/rabbitmq@7264d76: Update 4.0 to openssl 3.5.3 - docker-library/rabbitmq@c879782: Update 4.0 to 4.0.9 - docker-library/rabbitmq@85ee627: Update 4.0 to 4.0.8 - docker-library/rabbitmq@1519c4c: Merge pull request docker-library/rabbitmq#779 from lukebakken/lukebakken/fix-warnings
Changes: - docker-library/rabbitmq@14b8a4a: Update 4.0 to openssl 3.5.4 - docker-library/rabbitmq@7264d76: Update 4.0 to openssl 3.5.3 - docker-library/rabbitmq@c879782: Update 4.0 to 4.0.9 - docker-library/rabbitmq@85ee627: Update 4.0 to 4.0.8 - docker-library/rabbitmq@1519c4c: Merge pull request docker-library/rabbitmq#779 from lukebakken/lukebakken/fix-warnings
Changes: - docker-library/rabbitmq@8e6c07c: Merge pull request docker-library/rabbitmq#780 from lukebakken/lukebakken/docker-librarygh-768-rabbitmqadmin-ng - docker-library/rabbitmq@dac149a: Add Rust-based `rabbitmqadmin-ng` and remove Python - docker-library/rabbitmq@14b8a4a: Update 4.0 to openssl 3.5.4 - docker-library/rabbitmq@7264d76: Update 4.0 to openssl 3.5.3 - docker-library/rabbitmq@c879782: Update 4.0 to 4.0.9 - docker-library/rabbitmq@85ee627: Update 4.0 to 4.0.8 - docker-library/rabbitmq@1519c4c: Merge pull request docker-library/rabbitmq#779 from lukebakken/lukebakken/fix-warnings
Changes: - docker-library/rabbitmq@0d65bb3: Merge pull request docker-library/rabbitmq#783 from infosiftr/refactor - docker-library/rabbitmq@c57ff6e: Slightly refactor new `rabbitmqadmin` code - docker-library/rabbitmq@8e6c07c: Merge pull request docker-library/rabbitmq#780 from lukebakken/lukebakken/docker-librarygh-768-rabbitmqadmin-ng - docker-library/rabbitmq@dac149a: Add Rust-based `rabbitmqadmin-ng` and remove Python - docker-library/rabbitmq@14b8a4a: Update 4.0 to openssl 3.5.4 - docker-library/rabbitmq@7264d76: Update 4.0 to openssl 3.5.3 - docker-library/rabbitmq@c879782: Update 4.0 to 4.0.9 - docker-library/rabbitmq@85ee627: Update 4.0 to 4.0.8 - docker-library/rabbitmq@1519c4c: Merge pull request docker-library/rabbitmq#779 from lukebakken/lukebakken/fix-warnings
Changes: - docker-library/rabbitmq@b9786fd: Merge pull request docker-library/rabbitmq#784 from infosiftr/alpine3.23 - docker-library/rabbitmq@f5aa704: Update to Alpine 3.23 - docker-library/rabbitmq@0d65bb3: Merge pull request docker-library/rabbitmq#783 from infosiftr/refactor - docker-library/rabbitmq@c57ff6e: Slightly refactor new `rabbitmqadmin` code - docker-library/rabbitmq@8e6c07c: Merge pull request docker-library/rabbitmq#780 from lukebakken/lukebakken/docker-librarygh-768-rabbitmqadmin-ng - docker-library/rabbitmq@dac149a: Add Rust-based `rabbitmqadmin-ng` and remove Python - docker-library/rabbitmq@14b8a4a: Update 4.0 to openssl 3.5.4 - docker-library/rabbitmq@7264d76: Update 4.0 to openssl 3.5.3 - docker-library/rabbitmq@c879782: Update 4.0 to 4.0.9 - docker-library/rabbitmq@85ee627: Update 4.0 to 4.0.8 - docker-library/rabbitmq@1519c4c: Merge pull request docker-library/rabbitmq#779 from lukebakken/lukebakken/fix-warnings
Changes: - docker-library/rabbitmq@8991001: Update 4.2 to rabbitmqadmin 2.18.0 - docker-library/rabbitmq@9b8508a: Update 4.1 to rabbitmqadmin 2.18.0 - docker-library/rabbitmq@a541e82: Update 4.0 to rabbitmqadmin 2.18.0 - docker-library/rabbitmq@7496c53: Update 3.13 to rabbitmqadmin 2.18.0 - docker-library/rabbitmq@b9786fd: Merge pull request docker-library/rabbitmq#784 from infosiftr/alpine3.23 - docker-library/rabbitmq@f5aa704: Update to Alpine 3.23 - docker-library/rabbitmq@0d65bb3: Merge pull request docker-library/rabbitmq#783 from infosiftr/refactor - docker-library/rabbitmq@c57ff6e: Slightly refactor new `rabbitmqadmin` code - docker-library/rabbitmq@8e6c07c: Merge pull request docker-library/rabbitmq#780 from lukebakken/lukebakken/docker-librarygh-768-rabbitmqadmin-ng - docker-library/rabbitmq@dac149a: Add Rust-based `rabbitmqadmin-ng` and remove Python - docker-library/rabbitmq@14b8a4a: Update 4.0 to openssl 3.5.4 - docker-library/rabbitmq@7264d76: Update 4.0 to openssl 3.5.3 - docker-library/rabbitmq@c879782: Update 4.0 to 4.0.9 - docker-library/rabbitmq@85ee627: Update 4.0 to 4.0.8 - docker-library/rabbitmq@1519c4c: Merge pull request docker-library/rabbitmq#779 from lukebakken/lukebakken/fix-warnings
Changes: - docker-library/rabbitmq@f3ddb20: Merge pull request docker-library/rabbitmq#785 from infosiftr/drop-3.13 - docker-library/rabbitmq@4395f70: Drop support for 3.13 - docker-library/rabbitmq@8991001: Update 4.2 to rabbitmqadmin 2.18.0 - docker-library/rabbitmq@9b8508a: Update 4.1 to rabbitmqadmin 2.18.0 - docker-library/rabbitmq@a541e82: Update 4.0 to rabbitmqadmin 2.18.0 - docker-library/rabbitmq@7496c53: Update 3.13 to rabbitmqadmin 2.18.0 - docker-library/rabbitmq@b9786fd: Merge pull request docker-library/rabbitmq#784 from infosiftr/alpine3.23 - docker-library/rabbitmq@f5aa704: Update to Alpine 3.23 - docker-library/rabbitmq@0d65bb3: Merge pull request docker-library/rabbitmq#783 from infosiftr/refactor - docker-library/rabbitmq@c57ff6e: Slightly refactor new `rabbitmqadmin` code - docker-library/rabbitmq@8e6c07c: Merge pull request docker-library/rabbitmq#780 from lukebakken/lukebakken/docker-librarygh-768-rabbitmqadmin-ng - docker-library/rabbitmq@dac149a: Add Rust-based `rabbitmqadmin-ng` and remove Python - docker-library/rabbitmq@14b8a4a: Update 4.0 to openssl 3.5.4 - docker-library/rabbitmq@7264d76: Update 4.0 to openssl 3.5.3 - docker-library/rabbitmq@c879782: Update 4.0 to 4.0.9 - docker-library/rabbitmq@85ee627: Update 4.0 to 4.0.8 - docker-library/rabbitmq@1519c4c: Merge pull request docker-library/rabbitmq#779 from lukebakken/lukebakken/fix-warnings
Changes: - docker-library/rabbitmq@f3ddb20: Merge pull request docker-library/rabbitmq#785 from infosiftr/drop-3.13 - docker-library/rabbitmq@4395f70: Drop support for 3.13 - docker-library/rabbitmq@8991001: Update 4.2 to rabbitmqadmin 2.18.0 - docker-library/rabbitmq@9b8508a: Update 4.1 to rabbitmqadmin 2.18.0 - docker-library/rabbitmq@a541e82: Update 4.0 to rabbitmqadmin 2.18.0 - docker-library/rabbitmq@7496c53: Update 3.13 to rabbitmqadmin 2.18.0 - docker-library/rabbitmq@b9786fd: Merge pull request docker-library/rabbitmq#784 from infosiftr/alpine3.23 - docker-library/rabbitmq@f5aa704: Update to Alpine 3.23 - docker-library/rabbitmq@0d65bb3: Merge pull request docker-library/rabbitmq#783 from infosiftr/refactor - docker-library/rabbitmq@c57ff6e: Slightly refactor new `rabbitmqadmin` code - docker-library/rabbitmq@8e6c07c: Merge pull request docker-library/rabbitmq#780 from lukebakken/lukebakken/gh-768-rabbitmqadmin-ng - docker-library/rabbitmq@dac149a: Add Rust-based `rabbitmqadmin-ng` and remove Python - docker-library/rabbitmq@14b8a4a: Update 4.0 to openssl 3.5.4 - docker-library/rabbitmq@7264d76: Update 4.0 to openssl 3.5.3 - docker-library/rabbitmq@c879782: Update 4.0 to 4.0.9 - docker-library/rabbitmq@85ee627: Update 4.0 to 4.0.8 - docker-library/rabbitmq@1519c4c: Merge pull request docker-library/rabbitmq#779 from lukebakken/lukebakken/fix-warnings Co-authored-by: Docker Library Bot <[email protected]>
The following warnings are emitted by
docker build:This PR addresses them.