Pass string values through "erl" for appropriate escaping #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosifkit
approved these changes
Oct 12, 2017
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Oct 13, 2017
- `docker`: add client-only Windows variants (docker-library/docker#75) - `ghost`: 0.11.12 - `rabbitmq`: escape special characters in config (docker-library/rabbitmq#201) - `redmine`: passenger 5.1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is roughly equivalent to using
var_exportin PHP. 😄 The end result of this simpleerlone-liner is that it takes a single argument and returns a copy of it safely Erlang-quoted:Closes #199
I've verified that the result of
RABBITMQ_DEFAULT_PASS=$'a\nb\nc'becomes{ default_pass, <<"a\nb\nc">> }, as expected (and RabbitMQ starts up successfully). I'm not sure whether newlines in a password actually makes any sense, but it might for other values, and this insulates us completely against needing to worry about specific characters or validation.