Skip to content

Reduce clone depth of official-images on Travis CI #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

PeterDaveHello
Copy link
Contributor

@PeterDaveHello PeterDaveHello commented Jul 23, 2018

Only the latest version of official-images repo is needed. We can speed up this part in the CI build.
(As you can see that the repository already has almost 9k commits)

@tianon
Copy link
Member

tianon commented Jul 23, 2018

Checking on the logs for the real-world time this line takes, the difference is ~1.21s before and ~1.09s after, so I'm not sure this is really necessary.

@tianon
Copy link
Member

tianon commented Jul 23, 2018

For reference:

@tao12345666333
Copy link
Contributor

@tianon I think the ~0.12s for Travis CI build jobs is no effect. And for human this is not really necessary.

@PeterDaveHello
Copy link
Contributor Author

I believe that various. The variation on Travis CI is not quite small, if the network is busier, the difference could be more notable, though it's still no really big deal I agree.

@jrbenito
Copy link

jrbenito commented Sep 5, 2018

Hi,
We should think this not as simple matter of time but a matter of waste resource. Why download entire history if needs only the last commit? Besides the 0.12s there is bandwidth costs applied to Travis and Github links. Why not play easy on bandwidth whenever possible?

I agree with @PeterDaveHello that time may vary according to network traffic and size of the repository.

@tianon
Copy link
Member

tianon commented Sep 5, 2018

Ok, bandwidth comparison is ~6.45MB vs ~489.32KB (which is still pretty negligible either way).

Even at 6.45MB, that's ~158 builds before we even reach a gigabyte of bandwidth.

@tianon
Copy link
Member

tianon commented Sep 5, 2018

To be clear: I'm not entirely opposed to this change, but I don't want to cascade this update to every other .travis.yml under https://github.com/docker-library because I don't see a compelling reason to generate so much churn.

@tao12345666333
Copy link
Contributor

@tianon Yeah, I think that's too small a gain compared to the cost of modifying it.

@PeterDaveHello
Copy link
Contributor Author

We growth of the official-images, the effect will actually being a little more bigger, currently, it takes > 10MB per clone, but anyway, I'll respect decision from maintainer, so won't send this PR to other repos. @tianon I've rebased and resolved the conflicts here, is it good to go now? Thanks.

Only the latest version of official-images repo is needed.
@RDIL
Copy link

RDIL commented May 21, 2020

I think this should be good to go if conflicts are resolved 👍

@yosifkit
Copy link
Member

We've moved on to using github actions(#473), so this is not needed.

@yosifkit yosifkit closed this May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants