-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Reduce clone depth of official-images on Travis CI #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Checking on the logs for the real-world time this line takes, the difference is ~1.21s before and ~1.09s after, so I'm not sure this is really necessary. |
@tianon I think the ~0.12s for Travis CI build jobs is no effect. And for human this is not really necessary. |
I believe that various. The variation on Travis CI is not quite small, if the network is busier, the difference could be more notable, though it's still no really big deal I agree. |
Hi, I agree with @PeterDaveHello that time may vary according to network traffic and size of the repository. |
Ok, bandwidth comparison is ~6.45MB vs ~489.32KB (which is still pretty negligible either way). Even at 6.45MB, that's ~158 builds before we even reach a gigabyte of bandwidth. |
To be clear: I'm not entirely opposed to this change, but I don't want to cascade this update to every other |
@tianon Yeah, I think that's too small a gain compared to the cost of modifying it. |
We growth of the |
Only the latest version of official-images repo is needed.
I think this should be good to go if conflicts are resolved 👍 |
We've moved on to using github actions(#473), so this is not needed. |
Only the latest version of official-images repo is needed. We can speed up this part in the CI build.
(As you can see that the repository already has almost 9k commits)