-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Functionalize the entrypoint to allow outside sourcing for extreme customizing of startup #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
48f2ad1
Functionalize the entrypoint to allow outside sourcing for extreme cu…
yosifkit 49fb876
Namespace functions for less conflict when sourced
yosifkit 2e70e71
Apply function name changes as discussed in https://github.com/docker…
yosifkit 6e85168
Resync function interfaces with MySQL, improve comments
yosifkit d1cc089
Improve _is_sourced check
yosifkit 7c84645
Apply update.sh for new entrypoint
yosifkit 8fada98
Fixes from tianon's review
yosifkit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing in
$@
here for the temporary server is technically a minor change in behavior, but IMO it's really a bug that we weren't doing that before now (and this PR itself gives folks the ability to customize all of this to their hearts desires, including whether to pass$@
here or not 👍).