Use already available curl and consistent code style #843
Conversation
|
I'm half tempted to just remove Does php itself (or pecl/pear) use Though we probably wouldn't be the only dependent image that assumes |
|
I agree, including `curl` in the image itself instead of just `libcurl` to
satisfy PHP's `curl` plugin seems odd and I wish we had more history to see
why we added it in the first place.
|
|
curl is also used in tests: For Alpine most |
Maybe this has been enhanced? |
|
The transition to Alpine 3.10 (#845)/Debian Buster might be a good chance to remove |
|
That's a good idea -- perhaps we should also do so for 7.4-rc+, although I think this is enough change for one PR (I added a few extra bits and did a rebase). 👍 |
Changes: - docker-library/php@2e2df06: Merge pull request docker-library/php#843 from J0WI/curl - docker-library/php@250c2d8: Add "set -u" and more consistency - docker-library/php@82d590a: Use already available curl and consistent code style - docker-library/php@c0f68b2: Merge pull request docker-library/php#845 from J0WI/alpine10 - docker-library/php@27cfb71: Update default to Alpine 3.10 - docker-library/php@3802051: Add Alpine 3.10
Changes: - docker-library/php@04e67dc: Merge pull request docker-library/php#850 from petk/patch-php-7.4-alpha - docker-library/php@820403d: Also remove "update.sh" bits for ARGON2 hack removal - docker-library/php@894ee59: Remove the Alpine argon2 library fix - docker-library/php@2e2df06: Merge pull request docker-library/php#843 from J0WI/curl - docker-library/php@250c2d8: Add "set -u" and more consistency - docker-library/php@82d590a: Use already available curl and consistent code style - docker-library/php@c0f68b2: Merge pull request docker-library/php#845 from J0WI/alpine10 - docker-library/php@27cfb71: Update default to Alpine 3.10 - docker-library/php@3802051: Add Alpine 3.10
Changes: - docker-library/php@bbcc3db: Update to 7.4.0alpha2 - docker-library/php@eaa29e4: Merge pull request docker-library/php#851 from infosiftr/with-pear - docker-library/php@e2331f5: Add "--with-pear" in 7.4 - docker-library/php@04e67dc: Merge pull request docker-library/php#850 from petk/patch-php-7.4-alpha - docker-library/php@820403d: Also remove "update.sh" bits for ARGON2 hack removal - docker-library/php@894ee59: Remove the Alpine argon2 library fix - docker-library/php@2e2df06: Merge pull request docker-library/php#843 from J0WI/curl - docker-library/php@250c2d8: Add "set -u" and more consistency - docker-library/php@82d590a: Use already available curl and consistent code style - docker-library/php@c0f68b2: Merge pull request docker-library/php#845 from J0WI/alpine10 - docker-library/php@27cfb71: Update default to Alpine 3.10 - docker-library/php@3802051: Add Alpine 3.10
No description provided.