This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Catch errors when scraping datadir from help output #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you planning to update this with the changes from docker-library/mysql#218, or would you rather be responsible for maintaining the delta? 😄 😉 |
|
I'll be syncing all the changes tomorrow, so don't merge this or MariaDB/mariadb-docker#84. |
yosifkit
force-pushed
the
fix-datadir-scrape
branch
from
20b4649 to
eecb8dc
Compare
|
Changes have been re-synced to this and MariaDB/mariadb-docker#84 which also gets us the |
tianon
suggested changes
Oct 13, 2016
| @@ -43,7 +61,7 @@ if [ "$1" = 'mysqld' -a -z "$wantHelp" ]; then | |||
| mkdir -p "$DATADIR" | |||
|
|
|||
| echo 'Initializing database' | |||
| mysql_install_db --datadir="$DATADIR" --rpm | |||
| mysql_install_db --datadir="$DATADIR" --rpm --keep-my-cnf | |||
- also, sync `nullglob` from mysql entrypoint
yosifkit
force-pushed
the
fix-datadir-scrape
branch
from
eecb8dc to
9688bf1
Compare
tianon
approved these changes
Oct 13, 2016
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Oct 14, 2016
- `mariadb`: sync entrypoint changes (MariaDB/mariadb-docker#84) - `mysql`: add 8.0.0 DMR (docker-library/mysql#220) - `opensuse`: update Tumbleweed - `percona`: sync entrypoint changes (docker-library/percona#27) - `php`: 7.0.12 - `ruby`: bundler 1.13.4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, a user would just get the container exiting and zero output. Now a user will get some friendly output about the command that was run and then the error messages that mysqld emitted.
See also docker-library/mysql#218