Skip to content

Add MySQL 8.0.0 DMR #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2016
Merged

Add MySQL 8.0.0 DMR #220

merged 1 commit into from
Oct 13, 2016

Conversation

TimWolla
Copy link
Contributor

@TimWolla TimWolla commented Oct 12, 2016

This adds a Dockerfile for MySQL 8.0. MySQL 8.0 has been released a month ago as a Development Milestone release. Thus it's not a full release, but they claim that it should be as stable as a release candidate.

Until MySQL 8.0 is stable / a GA release MySQL 5.7 should remain latest, allowing interested developers to check whether their application works fine using MySQL 8.0 by opting in. In fact I just switched over a development database of mine from 5.7 to 8.0 without any issues.

[timwolla@/s/D/o/mysql (8.0)]diff -Nurw 5.7/ 8.0/                                                                                                                                                           22:37:30
diff -Nurw 5.7/Dockerfile 8.0/Dockerfile
--- 5.7/Dockerfile  2016-10-12 22:23:08.341968479 +0200
+++ 8.0/Dockerfile  2016-10-12 22:23:08.573973717 +0200
@@ -29,8 +29,8 @@
 # gpg: key 5072E1F5: public key "MySQL Release Engineering <[email protected]>" imported
 RUN apt-key adv --keyserver ha.pool.sks-keyservers.net --recv-keys A4A9406876FCBD3C456770C88C718D3B5072E1F5

-ENV MYSQL_MAJOR 5.7
-ENV MYSQL_VERSION 5.7.15-1debian8
+ENV MYSQL_MAJOR 8.0
+ENV MYSQL_VERSION 8.0.0-dmr-1debian8

 RUN echo "deb http://repo.mysql.com/apt/debian/ jessie mysql-${MYSQL_MAJOR}" > /etc/apt/sources.list.d/mysql.list

@tianon
Copy link
Member

tianon commented Oct 12, 2016

Nice!

cc @ltangvald

@yosifkit
Copy link
Member

Changes seem fine to me. Can you add 8.0 to the travis file too.

diff 5.7/Dockerfile <( curl -fsSL https://raw.githubusercontent.com/TimWolla/mysql/965ff86a25b143059fab9c8ea69f7a2d3ec17814/8.0/Dockerfile)
32,33c32,33
< ENV MYSQL_MAJOR 5.7
< ENV MYSQL_VERSION 5.7.15-1debian8
---
> ENV MYSQL_MAJOR 8.0
> ENV MYSQL_VERSION 8.0.0-dmr-1debian8

diff 5.7/docker-entrypoint.sh <( curl -fsSL https://raw.githubusercontent.com/TimWolla/mysql/965ff86a25b143059fab9c8ea69f7a2d3ec17814/8.0/docker-entrypoint.sh)
# none

@TimWolla
Copy link
Contributor Author

Can you add 8.0 to the travis file too.

@yosifkit Sure thing. I just force pushed over my branch and the tests are running 👍

@ltangvald
Copy link
Collaborator

LGTM :)

While 8.0 has significant changes from 5.7, the process for installing and starting it up on Linux should be pretty much identical.

Just note that the dmr tag means we don't claim this is as stable as a release candidate (it should be, but we can't guarantee)

@TimWolla
Copy link
Contributor Author

While 8.0 has significant changes from 5.7, the process for installing and starting it up on Linux should be pretty much identical.

The Dockerfile ran fine for my quick test, both using a fresh database and one upgraded from the 5.7 Docker image. In case that there are issues left users opting into the DMR are the best way to find out 😄

@ltangvald
Copy link
Collaborator

Yeah, we added 8.0 images for mysql/mysql-server, pretty much just by copying the 5.7 source and switching the version :)

Note that upgrading from 5.7 to 8.0 is very much a one-way street, even without running mysql_upgrade, as it will replace much of the database metadata on the first startup.

@yosifkit yosifkit merged commit 659ea23 into docker-library:master Oct 13, 2016
@TimWolla TimWolla deleted the 8.0 branch October 14, 2016 10:21
tianon added a commit to infosiftr/stackbrew that referenced this pull request Oct 14, 2016
- `mariadb`: sync entrypoint changes (MariaDB/mariadb-docker#84)
- `mysql`: add 8.0.0 DMR (docker-library/mysql#220)
- `opensuse`: update Tumbleweed
- `percona`: sync entrypoint changes (docker-library/percona#27)
- `php`: 7.0.12
- `ruby`: bundler 1.13.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants