Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templatize and refactor 5.7+ entrypoint scripts #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templatize and refactor 5.7+ entrypoint scripts #471
Changes from all commits
f16150e
5a727ad
afceb7f
34f3ef2
a8aa1cf
ea73775
9e51c81
a9e8576
03bdbad
2242976
eb2821b
4672559
db12713
f9c185f
db2319e
33ba3e5
9f77ea5
ef9caa9
2fcb086
1503220
67f2bd3
5e10737
ae7b623
34ae313
c9600d2
f1abc95
915c792
9b90b1c
dfa4cb4
880bb34
04b03e0
71962c5
ce4d14d
964f6c2
125ac54
bbf5d01
06acf82
169471f
8a58acb
8d01eea
91785a5
206541a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still relevant? (It's not used in later invocations of
docker_process_sql
.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the only outstanding question and since it is about code that isn't new, I think we can put it in its own issue.