Skip to content

Fix a few minor issues with docker-entrypoint.sh for 8.0.11 #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2018
Merged

Fix a few minor issues with docker-entrypoint.sh for 8.0.11 #406

merged 1 commit into from
Apr 19, 2018

Conversation

tianon
Copy link
Member

@tianon tianon commented Apr 19, 2018

No description provided.

@tianon
Copy link
Member Author

tianon commented Apr 19, 2018

Here's an example of output from mysqld --help --verbose that tripped up our awk:

  --mysqlx-port-open-timeout[=#] 
                      How long X Plugin is going to retry binding of server
                      socket (in case of failure)

tianon
tianon commented Apr 19, 2018
View reviewed changes
8.0/docker-entrypoint.sh
@@ -143,7 +145,7 @@ if [ "$1" = 'mysqld' -a -z "$wantHelp" ]; then
-- or products like mysql-fabric won't work
SET @@SESSION.SQL_LOG_BIN=0;

SET PASSWORD FOR 'root'@'localhost'=PASSWORD('${MYSQL_ROOT_PASSWORD}') ;
ALTER USER 'root'@'localhost' IDENTIFIED BY '${MYSQL_ROOT_PASSWORD}' ;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-11.html#mysqld-8-0-11-deprecation-removal

The PASSWORD() function. Additionally, PASSWORD() removal means that SET PASSWORD ... = PASSWORD('auth_string') syntax is no longer available.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Using ALTER USER instead is what's done in mysql/mysql-server: https://github.com/mysql/mysql-docker/blob/6c4a6defc2f74a0b4b5eb54847f849463b92d5bb/8.0/docker-entrypoint.sh#L111)

@tianon
Copy link
Member Author

tianon commented Apr 19, 2018

8.0 is green, the rest of the Travis builds are unrelated (transitory) failures 👍

@tianon tianon merged commit 731720e into docker-library:master Apr 19, 2018
@tianon tianon deleted the 8.0 branch April 19, 2018 17:31
@tianon
Copy link
Member Author

tianon commented Apr 19, 2018

Probably also worth noting here the following commits:

  • ff62794 Move "latest" to 8.0 now that it's GA
  • 6662ac7 Update to 5.7.22-1debian9
  • d32482c Update to 5.5.60
  • e279ec9 Update to 5.6.40-1debian9

This was referenced Apr 19, 2018
Closed
Closed
tianon added a commit to infosiftr/mariadb that referenced this pull request Nov 12, 2018
@tianon
Port "_get_config" adjustments
d50c065 
This ports docker-library/mysql#406 over, which fixes 10.4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tianon