Skip to content

added tag to hello-world example for windows #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

larryclaman
Copy link
Contributor

Example as created doesn't work; needs image tag

Example as created doesn't work; needs image tag
@tianon
Copy link
Member

tianon commented Feb 22, 2021

Good catch!

On the details of the change, CI is failing because this needs to be updated in the Makefile as well:

-e 's!ubuntu bash!mcr.microsoft.com/windows/servercore powershell!g' \

@larryclaman
Copy link
Contributor Author

Makefile updated.

@tianon tianon merged commit a6fdcbf into docker-library:master Feb 23, 2021
@tianon
Copy link
Member

tianon commented Feb 23, 2021

Nice, thank you! 👍

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Feb 23, 2021
Changes:

- docker-library/hello-world@a6fdcbf: Add "ltsc2019" tag to example Windows one-liner (docker-library/hello-world#85)
- docker-library/hello-world@92f8ec3: Merge pull request docker-library/hello-world#80 from infosiftr/gitattributes
- docker-library/hello-world@93e0c55: Fix line endings on Windows with gitattributes
- docker-library/hello-world@9ef4804: Merge pull request docker-library/hello-world#73 from docker-library/github-actions
- docker-library/hello-world@bf64724: Add initial GitHub Actions CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants