Skip to content

Fix line endings on Windows with gitattributes #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

tianon
Copy link
Member

@tianon tianon commented Sep 30, 2020

Fixes #78

Tested successfully in an environment where I've set git config --global core.autocrlf true (and thus docker build --file Dockerfile.build https://github.com/docker-library/hello-world.git fails), and I've confirmed that docker build --file Dockerfile.build https://github.com/infosiftr/hello-world.git#gitattributes succeeds.

@yosifkit yosifkit merged commit 92f8ec3 into docker-library:master Sep 30, 2020
@yosifkit yosifkit deleted the gitattributes branch September 30, 2020 18:07
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Feb 23, 2021
Changes:

- docker-library/hello-world@a6fdcbf: Add "ltsc2019" tag to example Windows one-liner (docker-library/hello-world#85)
- docker-library/hello-world@92f8ec3: Merge pull request docker-library/hello-world#80 from infosiftr/gitattributes
- docker-library/hello-world@93e0c55: Fix line endings on Windows with gitattributes
- docker-library/hello-world@9ef4804: Merge pull request docker-library/hello-world#73 from docker-library/github-actions
- docker-library/hello-world@bf64724: Add initial GitHub Actions CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error in macro expansion for DOCKER_GREETING variable
2 participants