Add golang:1.9-alpine-3.7 #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ git diff --no-index 1.9/alpine3.6 1.9/alpine3.7
diff --git a/1.9/alpine3.6/Dockerfile b/1.9/alpine3.7/Dockerfile
index f9a6904..77aa5ef 100644
--- a/1.9/alpine3.6/Dockerfile
+++ b/1.9/alpine3.7/Dockerfile
@@ -1,4 +1,4 @@
-FROM alpine:3.6
+FROM alpine:3.7
RUN apk add --no-cache ca-certificates
|
tianon
reviewed
Dec 9, 2017
generate-stackbrew-library.sh
Outdated
| @@ -13,7 +13,7 @@ declare -A debianSuite=( | |||
| defaultAlpineVersion='3.7' | |||
| declare -A alpineVersion=( | |||
| [1.8]='3.5' | |||
| [1.9]='3.6' | |||
| [1.9]='3.7' | |||
There was a problem hiding this comment.
This one should be left at 3.6 -- this controls what golang:1.9-alpine points to, which needs to stay at 3.6.
|
Thanks to you for the ultra quick review. |
|
Yeah, once the image is actually updated (which will likely happen on
Monday).
|
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Dec 12, 2017
- `bash`: apply Alpine patch to 4.4 for process substitution hang (tianon/docker-bash#4) - `golang`: add `alpine3.7` variant of 1.9 (docker-library/golang#192) - `rabbitmq`: add 3.7, which includes a new configuration file format (docker-library/rabbitmq#197) - `ruby`: remove `2.5-rc-alpine3.6` variant (superseded by `2.5-rc-alpine3.7`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would provide a stable golang image on alpine3.7 in the wait of go1.10