Adjust knex-migrator to be in the PATH directly instead of symlinking #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome ;) |
|
When you use |
|
Yes. But there is no need to install it via npm cause it is inside the
Ghost dependencies.
I think a good target is to keep the the images smaller.
The knex is taking lot of space... So why we need to have it 2 times?
…On Nov 10, 2017 14:02, "Christoph (Sheogorath) Kern" < ***@***.***> wrote:
When you use npm to execute it, there is no need to symlink or path it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIgO9uiBQkGGbi7SRM6DebLm2cvqqg6ks5s1ElVgaJpZM4QV00->
.
|
|
I'm not saying installing it, I say running it. Using |
|
@SISheogorath that'll work for our own usage, but not for folks who've extended this image and want to use If the |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Nov 15, 2017
- `ghost`: 1.17.2, `knex-migrator` direct in `PATH` (docker-library/ghost#105) - `mariadb`: 10.1.29, `gosu` 1.10 (MariaDB/mariadb-docker#139) - `php`: argon2 password hashing in 7.2+ (docker-library/php#521) - `postgres`: `--xlogdir` -> `--waldir` in 10+ (docker-library/postgres#374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103
Thanks @mmornati