std.net.curl: Move asynchronous stuff to lazily-instantiated namespace #6122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request, @CyberShadow! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
approved these changes
Feb 4, 2018
Contributor
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
Nice! Do you prefer the static: attribute label or the static attribute directly on the function?
| * If no data is available and the main thread accesses the range it will block | ||
| * until data becomes available. An exception to this is the $(D wait(Duration)) method on | ||
| * the $(LREF AsyncLineInputRange). This method will wait at maximum for the | ||
| * the $(LREF LineInputRange). This method will wait at maximum for the |
std/net/curl.d
Outdated
| // @@@@BUG 15831@@@@ | ||
| // this should be inside byLineAsync | ||
| // Range that reads one chunk at a time asynchronously. | ||
| private static struct ChunkInputRange |
Member
Author
There was a problem hiding this comment.
This one is safe to remove; not sure about the rest at a glance, since static can have additional effects on templates.
Member
Author
There was a problem hiding this comment.
Err actually there were two more non-templated functions.
CyberShadow
force-pushed
the
std-net-curl-async-ns
branch
from
5a4749d to
89bf93d
Compare
Allows avoiding importing std.concurrency unless asynchronous functionality actually needed. Improves impact on import time by about 15%.
CyberShadow
force-pushed
the
std-net-curl-async-ns
branch
from
89bf93d to
d60fcf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows avoiding importing std.concurrency unless asynchronous functionality actually needed.
Improves impact on import time by about 15%.
#5916 (comment)