Document Placement NewExpression #4161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
requested review from
andralex,
maxhaton and
mdparker
as code owners
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
rikkimax
approved these changes
Jan 14, 2025
rikkimax
added
the
72h no objection -> merge
|
If it is not appropriate to merge in 72 hours, feel free to take off the tag. |
WalterBright
force-pushed
the
PlacementNew
branch
from
2c73e49 to
eb6cbf0
Compare
|
I cannot merge it anyway until the dmd PR is merged, as otherwise the code examples will not work. |
rikkimax
removed
the
72h no objection -> merge
|
@WalterBright Is this ready to be merged now? |
ntrel
previously requested changes
Sep 12, 2025
spec/expression.dd
Outdated
| $(P The lifetime of the object presented as an lvalue ends with the execution of the $(I NewExpression), | ||
| and a new lifetime of the placed object starts after the execution.) | ||
|
|
||
| $(SPEC_RUNNABLE_EXAMPLE_COMPILE |
There was a problem hiding this comment.
All 3 examples should be SPEC_RUNNABLE_EXAMPLE_RUN, so the auto-tester checks the asserts.
|
Can someone fix the pending comments to have this PR merged? |
Co-authored-by: Nick Treleaven <[email protected]>
thewilsonator
approved these changes
Oct 20, 2025
thewilsonator
dismissed
ntrel’s stale review
applied suggested changes; examples now runnable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: dlang/dmd#17057