-
-
Notifications
You must be signed in to change notification settings - Fork 380
Generalize SPEC_HEADERNAV to HEADERNAV #2072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
6e9abfe
to
6b0030c
Compare
6b0030c
to
09abd01
Compare
FYI tests failing (undefined macros). |
09abd01
to
2580829
Compare
Hehe I'm so glad we added this sanity check :) diff --git a/web/ascii-table.html b/web/ascii-table.html
index 5158ca7..0f8e962 100644
--- a/web/ascii-table.html
+++ b/web/ascii-table.html
@@ -89,7 +89,7 @@
<div > If you spot a problem with this page, click here to create a Bugzilla issue.
</div>
</div>
- <div class="tip smallprint"> <a href="https://github.com/dlang/dlang.org/edit/master/ascii-table.dd">Improve this page</a>
+ <div class="tip smallprint"> <a href="https://github.com/dlang/dlang.org/edit/master/__stdin.d">Improve this page</a>
<div > Quickly fork, edit online, and submit a pull request for this page.
Requires a signed-in GitHub account. This works well for small changes.
If you'd like to make larger changes you may want to consider using I added a quick commit to test how easy it would be to inject "dynamic" macros with a simple trick. I really want to avoid re-implementing Ddoc. |
3ea25f4
to
933dde9
Compare
@CyberShadow or others: This is ready now. diff --git a/web/spec/property.html b/web/spec/property.html
index 19d2881..f2d8017 100644
--- a/web/spec/property.html
+++ b/web/spec/property.html
@@ -94,7 +94,7 @@
<div > If you spot a problem with this page, click here to create a Bugzilla issue.
</div>
</div>
- <div class="tip smallprint"> <a href="https://github.com/dlang/dlang.org/edit/master/__stdin.d">Improve this page</a>
+ <div class="tip smallprint"> <a href="https://github.com/dlang/dlang.org/edit/master/spec/property.dd">Improve this page</a>
<div > Quickly fork, edit online, and submit a pull request for this page.
Requires a signed-in GitHub account. This works well for small changes.
If you'd like to make larger changes you may want to consider using |
So this fixes the "Improve this page" link for all spec pages and - even though it changes a couple of pages - it is pretty trivial. However, if the number if changes is a problem I can also split them of into a separate PR. |
933dde9
to
e17a834
Compare
Rebasing this gets tedious - any reason for not moving forward with this? |
e17a834
to
02054d0
Compare
(another rebase) |
With the DDoc wrapper it's now pretty easy to do cool things without big Makefile hacks.
This PR now uses the Ddoc wrapper for all Ddoc pages and as a motivation starts to add HEADERNAV to a few pages.