Use un-synchronized Collections instead of Java2 Vector #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result objects returned by the proxy don't need to be synchronized. However, the Vector class is fully synchronized for backwards compatibility (it's around since Java 2). This change uses the more lightweight ArrayList, and the Collections.emptyList() singleton where applicable.
Contributor
Author
|
Obviously, feel free to decline this change if you don't find it appropriate. |
Owner
|
Seems to be cleaner and more modern, thanks! |
dka23
added a commit
that referenced
this pull request
Sep 29, 2015
Use un-synchronized Collections instead of Java2 Vector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result objects returned by the proxy don't need to be synchronized.
However, the Vector class is fully synchronized for backwards compatibility (it's around since Java 2). This change uses the more lightweight ArrayList, initialized with the approximate target size, and the Collections.emptyList() singleton where applicable.
Since the project uses Java 7 anyway, I used diamond notation where possible.