Skip to content

Conversation

@icex2
Copy link
Contributor

@icex2 icex2 commented Feb 23, 2024

feat(avs): Add property get and clear error functions

Use these to improve error handling by allowing
one to provide additional error information on
property related operations.


Stack created with Sapling. Best reviewed with ReviewStack.

Copy link
Collaborator

@willxinc willxinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty self explanatory, looks good to me
why does property_clear_error return a property*, is it just a passthrough?

icex2 added 2 commits February 25, 2024 08:51
Apparently forgotten to get updated to reflect the
currently supported versions correctly.
Allow hooks to cleanup when they are shut down.
icex2 added 2 commits February 25, 2024 09:14
Improve the development experience by providing
an additional docker container that can be started
and used as an interactive development environment.
It provides all the tools and a stable environment
for building (identical to the build container).
Use these to improve error handling by allowing
one to provide additional error information on
property related operations.
@icex2
Copy link
Contributor Author

icex2 commented Feb 25, 2024

pretty self explanatory, looks good to me why does property_clear_error return a property*, is it just a passthrough?

Don't ask me. =)
The original implementations do that because reasons.

@icex2 icex2 merged commit a4b3f92 into master Feb 25, 2024
@icex2 icex2 deleted the pr288 branch February 25, 2024 08:23
@icex2
Copy link
Contributor Author

icex2 commented Feb 25, 2024

pretty self explanatory, looks good to me why does property_clear_error return a property*, is it just a passthrough?

Don't ask me. =) The original implementations do that because reasons.

Have to correct my statement, see #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants