chore: refine allbridge header #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathaypacific
approved these changes
Feb 25, 2025
src/apps/allbridge/api.ts
Outdated
| (options) => { | ||
| logger.debug('allbridge: request details', { | ||
| url: options.url.toString(), | ||
| headers: options.headers, |
Contributor
There was a problem hiding this comment.
we don't use any api tokens / authentication in the headers that could be logged here right?
src/apps/allbridge/api.ts
Outdated
Comment on lines
103
to
136
| hooks: { | ||
| beforeRequest: [ | ||
| (options) => { | ||
| logger.debug('allbridge: request details', { | ||
| url: options.url.toString(), | ||
| headers: options.headers, | ||
| method: options.method, | ||
| }) | ||
| }, | ||
| ], | ||
| beforeError: [ | ||
| (error) => { | ||
| logger.error('allbridge: request error', { | ||
| statusCode: error.response?.statusCode, | ||
| statusMessage: error.response?.statusMessage, | ||
| responseHeaders: error.response?.headers, | ||
| responseBody: error.response?.body, | ||
| url: error.options?.url?.toString(), | ||
| requestHeaders: error.options?.headers, | ||
| }) | ||
| return error | ||
| }, | ||
| ], | ||
| afterResponse: [ | ||
| (response) => { | ||
| logger.debug('allbridge: response received', { | ||
| statusCode: response.statusCode, | ||
| headers: response.headers, | ||
| }) | ||
| return response | ||
| }, | ||
| ], | ||
| }, | ||
| }) |
Member
There was a problem hiding this comment.
src/apps/allbridge/positions.ts
Outdated
Comment on lines
54
to
64
| ? client | ||
| .readContract({ | ||
| address: tokenInfo.poolAddress, | ||
| abi: poolAbi, | ||
| functionName: 'balanceOf', | ||
| args: [address as Address], | ||
| }) | ||
| .catch((e) => { | ||
| logger.error('allbridge: failed to fetch balanceOf', e) | ||
| throw e | ||
| }) |
bakoushin
changed the title
jeanregisser
approved these changes
Feb 25, 2025
src/apps/allbridge/api.ts
Outdated
| .get('https://core.api.allbridgecoreapi.net/token-info') | ||
| .get('https://core.api.allbridgecoreapi.net/token-info', { | ||
| headers: { | ||
| 'x-Sdk-Agent': 'AllbridgeCoreSDK/0.0.0-development', // as in https://github.com/allbridge-io/allbridge-core-js-sdk/blob/5deb0623d6fffcbc7a85dba22b98942c47d4af6c/src/client/core-api/api-client.ts#L48 |
Member
There was a problem hiding this comment.
Looks like the shipped libs have a real value: 3.21.0 for the latest version
https://www.npmjs.com/package/@allbridge/bridge-core-sdk?activeTab=code
Contributor
Author
There was a problem hiding this comment.
good catch, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting an allbridge request header similar to the official SDK in an attempt to get rid of the 403 response
Context: https://valora-app.slack.com/archives/C02N3AR2P2S/p1740482746542719