Add support for tasks #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rh-gvincent
force-pushed
the
add_tasks
branch
4 times, most recently
from
2b5f981 to
e408ebb
Compare
Contributor
Author
|
recheck |
3 similar comments
Contributor
Author
|
recheck |
Contributor
Author
|
recheck |
Contributor
Author
|
recheck |
rh-gvincent
force-pushed
the
add_tasks
branch
9 times, most recently
from
257cfe2 to
aa9026b
Compare
In DCI we can create tasks attached to a jobstate. This patch add the support for the tasks endpoints. Depends-On: distributedci/dci-control-server#19
fcharlier
requested changes
Jan 6, 2026
Contributor
fcharlier
left a comment
fcharlier
left a comment
There was a problem hiding this comment.
one detail inline.
lgtm else.
| r = requests.get(location, stream=True) | ||
| r.raise_for_status() | ||
| with open(file_path + ".part", "wb") as f: | ||
| for chunk in r.iter_content(chunk_size=1024): |
Contributor
There was a problem hiding this comment.
Chunk size 1KB seems too small to me, no need to loop 1000 times to get 1MB of data with modern network bandwidth.
We can very safely fetch/write at least 64KB chunks (even up to 1MB would be find), it should allow to download 99% of the task files we have in DCI in one iteration and still limit the # of iterations to something not too crazy for the larger files.
File size stats in bytes for tasks since 2026-01-01:
min | max | avg | 75 pct | 90 pct | 95 pct | 99 pct | 99.5 pct | 99.9 pct
-----+----------+-----------------------+--------+--------+--------+--------+----------+----------
1 | 27897896 | 6158.9794323289321501 | 564 | 2346 | 7903 | 62466 | 166466 | 836602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DCI we can create tasks attached to a jobstate. This patch add the support for the tasks endpoints.
Depends-On: distributedci/dci-control-server#19