Fix possible use-before-assign bug #3505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
approved these changes
Jul 26, 2023
Member
dbutenhof
left a comment
dbutenhof
left a comment
There was a problem hiding this comment.
It seems unlikely that we could hit an exception on the statement you moved; but moving it outside of the try makes me inexplicably nervous anyway. 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Cache Manager
make_cache_object()function there is a possible use-before-assignment hazard. This PR addresses that by ensuring that, in the unlikely event that the assignment fails, we won't execute the use.(This was a part of #3501, but I decided to pull it out into its own PR.)