Correct OIDC URL generation and raise max payload size #3486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
previously approved these changes
Jul 7, 2023
ndokos
previously approved these changes
Jul 7, 2023
dbutenhof
approved these changes
Jul 7, 2023
ndokos
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides two small changes identified during Pbench Server "Ops review" sessions.
The first change raises the max request payload size to 100Gb. The existing limit of 10Gb is too small for certain users' requests.
The other changes is a follow-on to #3427. This PR replaces a couple of
urljoin()calls with simple string concatenation, since that function doesn't behave as expected when the configured OIDC server URL contains a partial path.