Add URI to TOC API #3471
Merged
Add URI to TOC API #3471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
added
Server
Dashboard
webbnh
previously approved these changes
Jun 26, 2023
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
Looks OK to me. Just a couple of small comments/questions.
PBENCH-624
We're not quite ready to rebuild the `/datasets/{dataset}/contents` API on the
cache manager. (I actually tried; it's not all there, and currently would need
to be built via a full tarball unpack each time we build a `CacheManager`
instance, while the changes to persist it via SQL or Redis, which I'd like to
do soon, seemed too big a lift right now.)
However, we have planned for some time to supplement the TOC information with
a uri element for each file and subdirectory; this much smaller change makes the
code match the API documentation.
With these changes, it's possible to navigate down the directory hierarchy. Navigating backwards on the "breadcrumb" line (still) doesn't quite work, but I now believe that my URI change in the API hasn't made anything worse than it was before.
ndokos
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-624
We're not quite ready to rebuild the
/datasets/{dataset}/contentsAPI on the cache manager. (I actually tried; it's not all there, and currently would need to be built via a full tarball unpack each time we build aCacheManagerinstance, while the changes to persist it via SQL or Redis, which I'd like to do soon, seemed too big a lift right now.)However, we have planned for some time to supplement the TOC information with a uri element for each file and subdirectory; this much smaller change makes the code match the API documentation.