Dashboard API Key Management #3423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbnh
requested changes
May 17, 2023
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
Looks good for the most part, but there's a spot where I think we are mutating the Redux store. Other than that, I've just got pointed questions and suggestions.
dashboard/src/modules/components/ProfileComponent/KeyListTable.jsx
Outdated
Show resolved
Hide resolved
dashboard/src/modules/components/ProfileComponent/KeyListTable.jsx
Outdated
Show resolved
Hide resolved
dashboard/src/modules/components/ProfileComponent/NewKeyModal.jsx
Outdated
Show resolved
Hide resolved
dbutenhof
reviewed
May 17, 2023
Member
dbutenhof
left a comment
dbutenhof
left a comment
There was a problem hiding this comment.
I think this looks great already, although Webb has some good cleanup suggestions I'd like to see added.
dashboard/src/modules/components/ProfileComponent/KeyListTable.jsx
Outdated
Show resolved
Hide resolved
Dashboard API Key Management Develop a UI page where a logged-in user can generate a new key for their account and manage existing keys. GET API keys New API key Modal
dbutenhof
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1131
Dashboard API Key Management
Develop a UI page where a logged-in user can generate a new key for their account and manage existing keys.