Lock flask and Werkzeug below 2.3.0 for now #3400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Flask package update today breaks all Pbench authentication; it's not clear why, and until we can figure it out, let's lock Flask below 2.3 to avoid the issue. This also locks Werkzeug to match because that was causing issues in testing.
npalaska
approved these changes
Apr 25, 2023
npalaska
reviewed
Apr 25, 2023
| sdnotify | ||
| sqlalchemy>=1.4.23 | ||
| sqlalchemy_utils>=0.37.6 | ||
| Werkzeug<2.3.0 |
Member
There was a problem hiding this comment.
Did werkezeug 2.3.0 work? Can we lock it with =
Member
There was a problem hiding this comment.
Never mind, I just tested it and yeah it needs <
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Flask package update today breaks all Pbench authentication; it's not clear why, and until we can figure it out, let's lock Flask below 2.3 to avoid the issue. This also locks Werkzeug to match because that was causing issues in testing.