Support generic sorting #3373
Merged
Support generic sorting #3373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
added
Server
Dashboard
dbutenhof
requested review from
MVarshini,
ndokos,
npalaska,
riya-17,
siddardh-ra and
webbnh
webbnh
reviewed
Apr 7, 2023
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
This looks great (I'm pleased that it was so easy, although some of the code looks familiar, which makes me wonder if there should be a refactoring somewhere), however, it could use some polishing.
dbutenhof
commented
Apr 10, 2023
webbnh
previously approved these changes
Apr 10, 2023
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
Looks good enough...unless you still want to change something.... 😉
PBENCH-1126 With pagination, a client (e.g., the dashboard) can't rely on client-side column sorting. Instead, add generalize sorting to `GET /datasets`, allowing the returned datasets to be sorted by any column or metadata value, either ascending (default) or descending. `GET /api/v1/datasets?sort=user.dashboard.favorite:desc,dataset.uploaded` will return all accessible datasets, sorted first by whether the authenticated user has marked the dataset "favorite" and second by the upload timestamp. (All "favorited" datasets will appear first, in upload order, followed by all "non- favorited" datasets in upload order.)
riya-17
approved these changes
Apr 12, 2023
portante
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1126
With pagination, a client (e.g., the dashboard) can't rely on client-side column sorting. Instead, add generalized sorting to
GET /datasets, allowing the returned datasets to be sorted by any column or metadata value, either ascending (default) or descending.GET /api/v1/datasets?sort=user.dashboard.favorite:desc,dataset.uploadedwill return all accessible datasets, sorted first by whether the authenticated user has marked the dataset "favorite" and second by the upload timestamp. (All "favorited" datasets will appear first, in upload order, followed by all "non- favorited" datasets in upload order.)