Integrate daterange into datasets API #3371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBENCH-1125 Remove the `GET /datasets/daterange` API in favor of a new query parameter, as `GET /datasets?daterange`. This allows getting the actual date range for any filtered selection of datasets.
dbutenhof
added
Server
API
webbnh
requested changes
Apr 6, 2023
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
Nice improvement!!
However, I think the docs (and possibly the code) need a tweak around the behavior when both keysummary and daterange are specified. And, I have some suggestions/nits.
Member
|
And, we need to get @npalaska to fix those flakey unit tests! 😉 |
Member
|
The indirect cause seems to be here: Apparently, somehow, the |
webbnh
previously approved these changes
Apr 6, 2023
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
Looks good, but I have an awkward question (or two) which probably means that we're missing a unit test.
webbnh
previously approved these changes
Apr 7, 2023
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
Looks good but for a typo. Also, I have a couple of suggestions.
dbutenhof
commented
Apr 7, 2023
Member
Author
dbutenhof
left a comment
dbutenhof
left a comment
There was a problem hiding this comment.
I'll fix the doc typo ...
riya-17
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1125
Remove the
GET /datasets/daterangeAPI in favor of a new query parameter, asGET /datasets?daterange. This allows getting the actual date range for any filtered selection of datasets.