-
Notifications
You must be signed in to change notification settings - Fork 107
Closed
Description
There are some existing issues and some arising from PR #3348 that should be addressed in the pbench-results-push tests (see test_resuls_push.py):
-
Some tests (e.g. the tests that test exceptions) can be subsumed under the parametrization of
add_http_mock_responsewith suitable changes so that the latter can accept an exception as well as a string for themessage). That will eliminateadd_connectionerr_mock_responseand the individual tests that use it. -
It might be better to specify the numeric value (400) rather than a symbolic name that happens to have the same value when deciding how to format the error message.
-
See also this suggestion for modifying the parametrization of the tests.
Metadata
Metadata
Assignees
Labels
No labels