Skip to content

Testing fixes for test_results_push.py #3374

@ndokos

Description

@ndokos

There are some existing issues and some arising from PR #3348 that should be addressed in the pbench-results-push tests (see test_resuls_push.py):

  • Some tests (e.g. the tests that test exceptions) can be subsumed under the parametrization of add_http_mock_response with suitable changes so that the latter can accept an exception as well as a string for the message). That will eliminate add_connectionerr_mock_response and the individual tests that use it.

  • It might be better to specify the numeric value (400) rather than a symbolic name that happens to have the same value when deciding how to format the error message.

  • See also this suggestion for modifying the parametrization of the tests.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions