Remove files list from status info; update README.md #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbnh
force-pushed
the
update-status-info
branch
from
de3918d to
79b8c13
Compare
Member
Author
|
Apparently I actually had tests for this stuff...converting to draft until I have them straightened out. 🥴 |
dbutenhof
previously approved these changes
Oct 20, 2023
Member
dbutenhof
left a comment
dbutenhof
left a comment
There was a problem hiding this comment.
S'OK, but a suggestion to make it more of an API ...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 98.52% 98.47% -0.05%
==========================================
Files 2 2
Lines 541 526 -15
==========================================
- Hits 533 518 -15
Misses 8 8
☔ View full report in Codecov by Sentry. |
dbutenhof
previously approved these changes
Oct 20, 2023
Member
dbutenhof
left a comment
dbutenhof
left a comment
There was a problem hiding this comment.
If you're improving the response, that's great; but I'm tossing a +1 anyway.
dbutenhof
approved these changes
Oct 20, 2023
Member
dbutenhof
left a comment
dbutenhof
left a comment
There was a problem hiding this comment.
Yeah, though, by the way, this really should have had a Jira issue. 👀
Member
Author
I attached it to PBENCH-1258. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're getting ready to deploy this in production, having the current list of files available is a security hazard. This PR removes that (leaving the disk utilization in the response, because that seems innocuous and even generally useful), and it brings the
README.mdfile up to date accordingly.