feat(REST): add CDNRoutes

[vvito7]

Please describe the changes this PR makes and why it should be merged:
Adds the constant CDNRoutes, that contains each CDN entpoint from DDevs Portal. Made it because of #453 (comment). With this, many other things are being added: ImageFormats, CDNQuery and *Format types.

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
discord-api-types	✅ Ready (Inspect)	Visit Preview	Jun 20, 2022 at 11:08PM (UTC)

[vladfrangu]

this PR doesn't add the last added CDN endpoint

It should, as the PR you linked adds it as a route, not a cdn route

[ImRodry]

Don't you wanna add a size parameter in every endpoint?

[vladfrangu]

Outside of defining them as interfaces, just like how we do for other rest endpoints, no. So, if @vvito7 wants to do that then they can, otherwise this is fineee

[didinele]

Should we maybe export & use types like EmojiFormat = Exclude<ImageFormat, ImageFormat.Lottie> instead of typing it out everywhere? It's more maintainable for both us and the end-user (i.e. if they write a function that takes a format it then passes it into our methods)

[vvito7]

Outside of defining them as interfaces, just like how we do for other rest endpoints, no. So, if @vvito7 wants to do that then they can, otherwise this is fineee

I could of course, but would it be something like this? I got a little confused

export interface RESTGetCDNRouteQuery {
	/**
	 * The returned image can have the size changed by using this query parameter
	 */
	size?: AllowedImageSizes;
}

export type AllowedImageSizes = 16 | 32 | 56 | 64 | 96 | 128 | 256 | 300 | 512 | 600 | 1024 | 2048 | 4096;

Should we maybe export & use types like EmojiFormat = Exclude<ImageFormat, ImageFormat.Lottie> instead of typing it out everywhere? It's more maintainable for both us and the end-user (i.e. if they write a function that takes a format it then passes it into our methods)

I like the idea 👍

[vladfrangu]

Outside of defining them as interfaces, just like how we do for other rest endpoints, no. So, if @vvito7 wants to do that then they can, otherwise this is fineee

I could of course, but would it be something like this? I got a little confused

export interface RESTGetCDNRouteQuery {
	/**
	 * The returned image can have the size changed by using this query parameter
	 */
	size?: AllowedImageSizes;
}

export type AllowedImageSizes = 16 | 32 | 56 | 64 | 96 | 128 | 256 | 300 | 512 | 600 | 1024 | 2048 | 4096;

Yes, but maybe we should just type size as a number? Also this can use a diff interface name (CDNQuery?) if you want

[vvito7]

maybe we should just type size as a number?

Yes, sure. But there is a bunch of numbers that don't work
I could just add the allowed sizes in the docs

Also this can use a diff interface name (CDNQuery?) if you want

Sure👍

[vladfrangu]

I could just add the allowed sizes in the docs

Well its just powers of 2 so... that should be easy enough

[ImRodry]

Except it isn’t

[vladfrangu]

Source?

[ImRodry]

Discord.js, discord docs, whatever floats your boat

[vladfrangu]

Well call me nuts because Discord says it themselves: https://discord.com/developers/docs/reference#image-formatting-image-base-url

The returned size can be changed by appending a querystring of ?size=desired_size to the URL. Image size can be any power of two between 16 and 4096.

[vvito7]

Tried to implement what @didinele said, but I don't think it's what they wanted. Also there is so many duplicated stuff
Let me know how I can improve it

[didinele]

That's basically it, just make each one a type rather than putting it under an interface, e.g.
type EmojiFormat = Exclude<ImageFormat, ImageFormat.Lottie>;

Also there is so many duplicated stuff

that's alright.