Skip to content

Reworked the circleci file to upload releases to Github. #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2019

Conversation

Rembane
Copy link
Contributor

@Rembane Rembane commented Mar 22, 2019

Moved circleci configuration file from circle.yml to
.circleci/config.yml to automatically work with circleci.com.

Removed lens-aeson since it isn't used.

Gave stm-containers an exact hard version bound to make the project
build with cabal new-build.

Moved circleci configuration file from circle.yml to
.circleci/config.yml to automatically work with circleci.com.

Removed lens-aeson since it isn't used.

Gave stm-containers an exact hard version bound to make the project
build with cabal new-build.
@Rembane
Copy link
Contributor Author

Rembane commented Mar 22, 2019

@diogob I just saw that that you had self-assigned the issue (#43) 11 days ago. I hope that you haven't put too much time into solving it and that you don't mind that I gave it a go.

This PR + commit is a draft of how to solve this problem, so feel free to give feedback, modify it and so on. The commit also solves two other problems, I can split them into other commits or PRs if you want to.

Known bugs

CircleCI always creates a new release when you push to master, and overwrites the old release with same tag.

@Rembane
Copy link
Contributor Author

Rembane commented Mar 23, 2019

Limitations and future work

Another limitation is that this CircleCI configuration only tests and builds releases. If it should run after each commit or on each pull request some more work needs to be done.

Every run of CircleCI takes about fifteen minutes. That's a long time and only give 66 free builds a month. We can make this faster by suppling a Docker image with all dependencies installed.

@diogob
Copy link
Owner

diogob commented Mar 23, 2019

@Rembane thanks for PR, much appreciated :D

@diogob diogob merged commit fcb335b into diogob:master Mar 23, 2019
@Rembane
Copy link
Contributor Author

Rembane commented Mar 23, 2019

No worries. It was fun! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants