Skip to content

Conversation

@fvgh
Copy link
Member

@fvgh fvgh commented Jun 30, 2019

The change fixes #413 .
The changes are backward compatible an have been tested with all current Spotless Eclipse base formatters.
The new version 3.2.0 is ready for release.
The CHANGES.md still contains TBD as release date.

@fvgh fvgh requested a review from nedtwigg June 30, 2019 11:52
@nedtwigg
Copy link
Member

nedtwigg commented Jul 1, 2019

Published to mavencentral. Another amazing PR!!! Were you an eclipse engineer at one time Frank? I've hacked around with similar stuff to make Goomph work, and the reverse-engineering was always difficult for me. This eclipse-base is very elegant, and works very well.

Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great!

@fvgh fvgh merged commit dbf857a into master Jul 1, 2019
@fvgh fvgh deleted the issue_413 branch July 1, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Eclipse 4.12 core runtime 3.15

3 participants