Skip to content

Remove isOtherLowercase and isOtherUppercase from the Character models #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2021
Merged

Remove isOtherLowercase and isOtherUppercase from the Character models #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c1f902
Add a github action to build Models Library on Github Actions.
NlightNFotis Sep 20, 2021
0bf463e
Remove Travis configuration.
NlightNFotis Sep 20, 2021
a912257
Remove `isOtherLowercase` and `isOtherUppercase` from the `Character`…
NlightNFotis Sep 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/models_library_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Build JBMC Java Models Library
on:
pull_request:
branches: [ master ]

jobs:
Build-Models-Library:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v2
- name: Setup Java environment
uses: actions/setup-java@v2
with:
java-version: '16'
distribution: 'adopt'
- name: Build with Maven
run: mvn package
12 changes: 0 additions & 12 deletions .travis.yml
View file
Open in desktop

This file was deleted.

14 changes: 10 additions & 4 deletions src/main/java/java/lang/Character.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5459,8 +5459,11 @@ public static boolean isLowerCase(char ch) {
* @since 1.5
*/
public static boolean isLowerCase(int codePoint) {
return getType(codePoint) == Character.LOWERCASE_LETTER ||
CharacterData.of(codePoint).isOtherLowercase(codePoint);
return getType(codePoint) == Character.LOWERCASE_LETTER;
// This code has been simplified in the upstream JDK repository
// at https://github.com/openjdk/jdk/pull/2846/files. The change
// below is to bring the code at parity with openJDK.
// || CharacterData.of(codePoint).isOtherLowercase(codePoint);
}

/**
Expand Down Expand Up @@ -5525,8 +5528,11 @@ public static boolean isUpperCase(char ch) {
* @since 1.5
*/
public static boolean isUpperCase(int codePoint) {
return getType(codePoint) == Character.UPPERCASE_LETTER ||
CharacterData.of(codePoint).isOtherUppercase(codePoint);
return getType(codePoint) == Character.UPPERCASE_LETTER;
// // This code has been simplified in the upstream JDK repository
// at https://github.com/openjdk/jdk/pull/2846/files. The change
// below is to bring the code at parity with openJDK.
// || CharacterData.of(codePoint).isOtherUppercase(codePoint);
}

/**
Expand Down