Remove isOtherLowercase and isOtherUppercase from the Character models
#35
Conversation
NlightNFotis
force-pushed
the
remove-character-methods
branch
from
c0d3fff to
5edc278
Compare
|
Hello @peterschrammel. I have implemented the changes you suggested. I'm assuming Travis is dead (or our config is super-broken); does this mean you have to merge manually? |
|
Can you add a simple github actions configuration to replace it? |
|
Hi @peterschrammel, yes, absolutely. I will spin one and rebase the current PR on top of the branch that contains it. |
For now it's using a simple platform array (`ubuntu-latest`, Java 16 JDK by Adoptium), but it can be enhanced later to feature support for multiple platforms or JDK versions.
It has gone stale over time and blocks PRs against Models Library from getting merged. Additionally, it has been substituted by a Github Action that has the same effect.
… models. These were removed in upstream commit https://github.com/openjdk/jdk/pull/2846/files and are now creating problems when trying to build the models library with openJDK-17.
NlightNFotis
force-pushed
the
remove-character-methods
branch
from
5edc278 to
a912257
Compare
|
Okay, @peterschrammel, a basic config for CI has been added. We could expand it to a more featureful array of platforms/environments, but it can also be done as a later step. What would be your preference? |
|
Alright @peterschrammel. The travis configuration will need to be removed from the Repository's settings as a required check as well, I believe, and then I should be able to merge. |
|
Should be ready now. |
These were removed in upstream commit https://github.com/openjdk/jdk/pull/2846/files
and are now creating problems when trying to build the models library with openJDK-17.