fix for netlist conversion #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
Sep 9, 2024
Comment on lines
+596
to
+599
| if(it->type().id() == ID_natural || it->type().id() == ID_integer) | ||
| continue; |
There was a problem hiding this comment.
Curious/would appreciate a comment in the code: Why is "ignore this" the right way to go here?
There was a problem hiding this comment.
Done -- this whole function should be replaced by a proper dependency graph, which could be reused elsewhere.
This fixes the case where the netlist conversion fails when there is an operand with natural or integer type. Fixes #674.
kroening
force-pushed
the
netlist-conversion1
branch
from
864967f to
b00ade6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where the netlist conversion fails when there is an operand with natural or integer type.
Fixes #674.