Verilog: assignment pattern expressions #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
assignment_pattern
branch
2 times, most recently
from
0577307 to
09f605a
Compare
tautschnig
reviewed
Jun 25, 2024
Comment on lines
+1636
to
+1657
| if(dest_type.id() == ID_struct) | ||
| { | ||
| auto &struct_type = to_struct_type(dest_type); | ||
| auto &components = struct_type.components(); | ||
|
|
||
| if(expr.operands().size() != components.size()) | ||
| { | ||
| throw errort().with_location(expr.source_location()) | ||
| << "number of expressions does not match number of struct members"; | ||
| } | ||
|
|
||
| for(std::size_t i = 0; i < components.size(); i++) | ||
| { | ||
| // rec. call | ||
| implicit_typecast(expr.operands()[i], components[i].type()); | ||
| } | ||
|
|
||
| // turn into struct expression | ||
| expr.id(ID_struct); | ||
| expr.type() = dest_type; | ||
| return; | ||
| } |
There was a problem hiding this comment.
The earlier comment said these could become structs or arrays -- are the latter just not yet implemented?
kroening
force-pushed
the
assignment_pattern
branch
2 times, most recently
from
fc9f676 to
f34f7e0
Compare
This adds support for struct and array literals to the SystemVerilog frontend by implementing the assignment_pattern_expression production rules.
kroening
force-pushed
the
assignment_pattern
branch
from
f34f7e0 to
8ee5500
Compare
tautschnig
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for struct and array literals to the SystemVerilog frontend by implementing the
assignment_pattern_expressionproduction rules.