Property description now taken from front-end #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
property-description
branch
2 times, most recently
from
ed250d3 to
d3d05aa
Compare
tautschnig
approved these changes
Jun 24, 2024
| xmlt xml("property"); | ||
| xml.set_attribute("name", id2string(p.name)); | ||
|
|
||
| xml.new_element("number").data = std::to_string(p_nr); // will go away |
There was a problem hiding this comment.
Just curious: what will go away and when?
There was a problem hiding this comment.
That's just a moved comment, not new. You can't use the number for anything (we use the property identifier instead), so it's really redundant.
kroening
force-pushed
the
property-description
branch
from
d3d05aa to
3baa85e
Compare
This moves the generation of the property description into the front-end, which will enable doing lowering or model instrumentation in the front-end while displaying the property as given in the source language.
kroening
force-pushed
the
property-description
branch
from
3baa85e to
00a34b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the generation of the property description into the front-end, which will enable doing lowering or model instrumentation in the front-end while displaying the property as given in the source language.