Skip to content

Conversation

kroening
Copy link
Collaborator

@kroening kroening commented Apr 2, 2024

This introduces a pass during which the given property is 'normalized', using heuristic rewrites, with the goal to reduce the burden of a large number of redundant case-splits in each backend.

@kroening kroening force-pushed the property-normalizer branch from 7e1b9dd to 305b4ef Compare April 2, 2024 17:45
@kroening kroening marked this pull request as ready for review April 2, 2024 19:28
Comment on lines +74 to +76
properties.properties.back().original_expr = symbol.value;
properties.properties.back().normalized_expr =
normalize_property(symbol.value);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll eventually want a non-default constructor for propertyt.


#include <util/expr.h>

exprt normalize_property(exprt);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add comments to describe what the normal form is that is being established?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

This introduces a pass during which the given property is 'normalized',
using heuristic rewrites, with the goal to reduce the burden of a large
number of redundant case-splits in each backend.
@kroening kroening force-pushed the property-normalizer branch from 305b4ef to b0031ef Compare April 15, 2024 00:47
@kroening kroening merged commit 5612fe0 into main Apr 15, 2024
@kroening kroening deleted the property-normalizer branch April 15, 2024 01:08
Romy15200 pushed a commit to Romy15200/nws that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants