ebmc: normalize properties #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
property-normalizer
branch
from
7e1b9dd to
305b4ef
Compare
tautschnig
approved these changes
Apr 3, 2024
Comment on lines
+74
to
+76
| properties.properties.back().original_expr = symbol.value; | ||
| properties.properties.back().normalized_expr = | ||
| normalize_property(symbol.value); |
There was a problem hiding this comment.
I think we'll eventually want a non-default constructor for propertyt.
|
|
||
| #include <util/expr.h> | ||
|
|
||
| exprt normalize_property(exprt); |
There was a problem hiding this comment.
Could you please add comments to describe what the normal form is that is being established?
This introduces a pass during which the given property is 'normalized', using heuristic rewrites, with the goal to reduce the burden of a large number of redundant case-splits in each backend.
kroening
force-pushed
the
property-normalizer
branch
from
305b4ef to
b0031ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a pass during which the given property is 'normalized', using heuristic rewrites, with the goal to reduce the burden of a large number of redundant case-splits in each backend.