Verilog: get_width now returns mp_integer
#417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
get_width_mp_integer
branch
from
c23b15c to
4290106
Compare
kroening
changed the title
get_widt now returns mp_integer
kroening
changed the title
get_widt now returns mp_integerget_width now returns mp_integer
tautschnig
reviewed
Mar 18, 2024
Comment on lines
2293
to
2302
| auto padding = from_integer( | ||
| 0, unsignedbv_typet{numeric_cast_v<unsigned>(padding_width)}); | ||
| auto new_type = unsignedbv_typet{ | ||
| numeric_cast_v<unsigned>(get_width(op0.type()) + padding_width)}; | ||
| expr.op0() = concatenation_exprt(padding, expr.op0(), new_type); | ||
| } | ||
|
|
||
| // Part-select expressions are unsigned, even if the | ||
| // entire expression is selected! | ||
| auto expr_type = unsignedbv_typet((op1 - op2).to_ulong() + 1); | ||
| auto expr_type = unsignedbv_typet{numeric_cast_v<unsigned>(op1 - op2 + 1)}; |
There was a problem hiding this comment.
Here and above: is it really ok to use the platform-dependent unsigned type?
There was a problem hiding this comment.
Changed to std::size_t -- however, I think I really want to change the constructor of the bitvector types to mp_integer. Client-code should not have to deal with this.
kroening
force-pushed
the
get_width_mp_integer
branch
from
4290106 to
35b444e
Compare
Merged
This avoids checking for overflows when adding up widths.
kroening
force-pushed
the
get_width_mp_integer
branch
from
35b444e to
8bfd27f
Compare
tautschnig
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids checking for overflows when adding up widths.