Overwrite String functions during bytecode conversion #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new implementation of the string preprocessing for Java functions. Which now takes place during java bytecode processing instead of being a step in the goto-program treatment. Rename code_of_function to code_for_function Update documentation Minor corrections on the code Make all methods non-static This is to allow using class variables in them. The conversion_functiont map had to be adapted. Use class variable for refined string type Instead of recreating a new refined string type each time it is requested, we add a field to hold it in java_string_library_preprocess.
…onversion Removing add_string_type declaration, not used anymore
Removing string_refine_preprocess from Makefile Removing include of string_refine_preprocess
Changes requested by Matthias Guedemann, Peter Schrammel, and Chris Smowton.
Replace code.copy_to_operands() with code.add()
Correct implementation and usage of string_length_type()
Replace all String functions in the preprocessing, even if they exist already (e.g. if a model exists). This implements issue diffblue/test-gen#360
String classes that are present in a loaded model will generate a type that may be different from the internal type constructed for Java strings in cbmc. Thus we now create a String type and write it in the table, possibly overwriting a pre-existing Java string type.
romainbrenguier
force-pushed
the
pull-request/override-string-functions
branch
from
f605190 to
e6531b1
Compare
|
This pull request is replaced by #983 so I'm closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all String functions in the preprocessing, even if they exist
already (e.g. if a model exists).
This implements issue diffblue/test-gen#360 .
This is based on PR #906