Skip to content

ansi-c: add "" around C++ keywords #8622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

ansi-c: add "" around C++ keywords #8622

merged 2 commits into from
Apr 9, 2025

Conversation

kroening
Copy link
Member

@kroening kroening commented Apr 9, 2025

For consistency with the other tokens, add quotes "" around the C++ keywords in the ansi-c scanner.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 48.83721% with 44 lines in your changes missing coverage. Please review.

Project coverage is 80.36%. Comparing base (10a14c9) to head (9fbdf4b).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
src/ansi-c/scanner.l 48.83% 44 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8622      +/-   ##
===========================================
- Coverage    80.38%   80.36%   -0.02%     
===========================================
  Files         1686     1686              
  Lines       206772   206799      +27     
  Branches        85       84       -1     
===========================================
- Hits        166213   166200      -13     
- Misses       40559    40599      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second commit looks good, for the first one see comment on the other PR.

kroening added 2 commits April 9, 2025 12:45
This introduces a helper function in the C scanner to deal with a larger
number of cases to enable or disable keywords of the various C/C++ dialects.
For consistency with the other tokens, add quotes "" around the C++ keywords.
@kroening kroening force-pushed the scanner-token-names branch from 2fecf08 to 9fbdf4b Compare April 9, 2025 16:48
@kroening kroening enabled auto-merge April 9, 2025 18:02
@kroening kroening merged commit cbdab7f into develop Apr 9, 2025
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants